Make the VIEW* parameter const. Since PCB_TEXT does a null-check,
it's not very clear if this can ever be null (and if it is,
why don't the other VIEW_ITEMs check?), so don't make them
all references too at this time.
Also dereference a few pointers a bit earlier to make non-null
promises sooner rather than later.
Saves a mishmash of local HIDE/SHOW defs along with various literals.
Also provide a function that computes the scale at which a given
IU size becomes (notionally) a certain size on screen. While this
is a simple division, it's a bit opaque in terms of meaning.
Also it means the divide by zero case can be more universally
defended-against, which has traditionally been a bug opportunity.
* Don't hide the annular rings control - makes confusing UI
* Always show annular rings control - all boards must have >2 layers
anyway
* Move into single column of choice boxes to be cleaner and take less
monitor space
https://gitlab.com/kicad/code/kicad/-/issues/19457
Make autoplace in the symbol preview based on the global eeschema
flag instead. (If they have it off, then they had better specify
field positions in the database library.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19247
Recommendation is to avoid using the year nomenclature as this
information is already encoded in the git repo. Avoids needing to
repeatly update.
Also updates AUTHORS.txt from current repo with contributor names
For this year's resolution, we will streamline our copyright statements.
These are applied to files in the repository and are not needed
separately as part of the compiled about box
This means when you switch a pad to be roundable (round rect or
chamfered-with-round), you get the same behaviour as in the dialog
(and an IPC-compliant pad by default).
Also fixes the radius visibility in the properties panel for
chamfered pads (which can have radii).
This can be useful when you have a defined rounding maximum
(e.g. for an IPC 0.25/0.25 rule) and makes the panel more
consistent with the properties dialog.
Also removes Open Directory button as in a job the filepath
will be relative to whichever Output it is placed in.
Also removes the Run DRC button when called from a job.
wxFormbuilder is not DPI aware so the previous height was a bit short on
high DPI displays. The new height is a compromise which will be a bit tall
on standard DPI displays and a bit short on high DPI displays.