From 27cff81ee75fb948dadced66ae16beab0bbc5f3b Mon Sep 17 00:00:00 2001 From: plc-user <74435298+plc-user@users.noreply.github.com> Date: Fri, 7 Mar 2025 10:58:47 +0100 Subject: [PATCH] adjust zoom-factor to use cosmetic-line and fixed comments --- sources/qetgraphicsitem/conductor.cpp | 4 ++-- sources/qetgraphicsitem/element.cpp | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/sources/qetgraphicsitem/conductor.cpp b/sources/qetgraphicsitem/conductor.cpp index 97312677c..9693976ca 100644 --- a/sources/qetgraphicsitem/conductor.cpp +++ b/sources/qetgraphicsitem/conductor.cpp @@ -519,8 +519,8 @@ void Conductor::paint(QPainter *painter, const QStyleOptionGraphicsItem *options final_conductor_pen.setStyle(m_properties.style); final_conductor_pen.setJoinStyle(Qt::SvgMiterJoin); // better rendering with dot - //Use a cosmetique line, below a certain zoom - if (options && options->levelOfDetailFromTransform(painter->worldTransform()) < 1.0) + //Use a cosmetic line, below a certain zoom + if (options && options->levelOfDetailFromTransform(painter->worldTransform()) < 0.5) { final_conductor_pen.setCosmetic(true); } diff --git a/sources/qetgraphicsitem/element.cpp b/sources/qetgraphicsitem/element.cpp index 31714c63b..a362b25d0 100644 --- a/sources/qetgraphicsitem/element.cpp +++ b/sources/qetgraphicsitem/element.cpp @@ -215,24 +215,24 @@ void Element::paint( drawHighlight(painter, options); } - //Set default pen and brush to QPainter - //for avoid a strange bug when the Qt theme is a "dark" theme. - //Some part of an element are gray or white instead of black. - //This bug seems append only when the QPainter use drawPicture method. + //Set default pen and brush to QPainter to avoid a strange bug when + //the Qt theme is a "dark" theme. + //Some parts of an element are gray or white instead of black. + //This bug seems append only when the QPainter uses drawPicture method. //See bug 175. https://qelectrotech.org/bugtracker/view.php?id=175 painter->save(); QPen pen; QBrush brush; painter->setPen(pen); painter->setBrush(brush); - if (options && options->levelOfDetailFromTransform(painter->worldTransform()) < 1.0) + if (options && options->levelOfDetailFromTransform(painter->worldTransform()) < 0.5) { painter->drawPicture(0, 0, m_low_zoom_picture); } else { painter->drawPicture(0, 0, m_picture); } - painter->restore(); //Restorr the QPainter after use drawPicture + painter->restore(); //Restore the QPainter after use drawPicture //Draw the selection rectangle if ( isSelected() || m_mouse_over ) {