mirror of
https://gitlab.com/kicad/code/kicad.git
synced 2025-09-14 18:23:15 +02:00
fef3274e8e
Fixes #10926 Contains the following changes: - Adds a new ERC_SCH_PIN_CONTEXT class which is used to provide deterministic comparison between items causing ERC violations (e.g. pins) when associated with a SCH_SHEET_PATH context. - Adds association of SCH_SHEET_PATHs for ERC_ITEMs and the sub-schematic items which caused an ERC violation. This allows correct display of markers on the sheets of interest only, and allows correct naming resolution and cross-probing from the ERC dialog. - Adds a new ERC_TREE_MODEL class, derived from RC_TREE_MODEL, which correctly resolves component references across heirarchical sheets using the associated SCH_SHEET_PATHs. This allows sheet-specific component references to be displayed correctly in the ERC results tree. - Updates SCH_MARKER to only draw sheet-specific markers on the sheet causing an ERC violation. - Increments the schematic file version. - When loading a schematic with legacy ERC exclusions, discards those of type ERCE_PIN_TO_PIN_WARNING, ERCE_PIN_TO_PIN_ERROR, ERCE_HIERACHICAL_LABEL, and ERCE_DIFFERENT_UNIT_NET as there is no safe way to automatically infer the information which is now stored with these exclusions (sheet paths for error location and related items). Requiring users to (once) re-add exclusions is preferable to silently incorrectly matching new ERC issues to legacy exclusions.
76 lines
2.5 KiB
C++
76 lines
2.5 KiB
C++
/*
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
*
|
|
* Copyright (C) 2022 KiCad Developers, see AUTHORS.TXT for contributors.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 3
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, you may find one at
|
|
* http://www.gnu.org/licenses/
|
|
*/
|
|
|
|
#include <qa_utils/wx_utils/unit_test_utils.h>
|
|
#include <schematic_utils/schematic_file_util.h>
|
|
|
|
#include <connection_graph.h>
|
|
#include <schematic.h>
|
|
#include <erc_settings.h>
|
|
#include <erc.h>
|
|
#include <settings/settings_manager.h>
|
|
#include <locale_io.h>
|
|
|
|
|
|
struct ERC_REGRESSION_TEST_FIXTURE
|
|
{
|
|
ERC_REGRESSION_TEST_FIXTURE() : m_settingsManager( true /* headless */ ) {}
|
|
|
|
SETTINGS_MANAGER m_settingsManager;
|
|
std::unique_ptr<SCHEMATIC> m_schematic;
|
|
};
|
|
|
|
|
|
BOOST_FIXTURE_TEST_CASE( ERCHierarchicalSchematics, ERC_REGRESSION_TEST_FIXTURE )
|
|
{
|
|
LOCALE_IO dummy;
|
|
|
|
// Check not-connected ERC errors
|
|
|
|
std::vector<std::pair<wxString, int>> tests = { { "issue10926_1", 3 } };
|
|
|
|
for( const std::pair<wxString, int>& test : tests )
|
|
{
|
|
KI_TEST::LoadSchematic( m_settingsManager, test.first, m_schematic );
|
|
|
|
ERC_SETTINGS& settings = m_schematic->ErcSettings();
|
|
SHEETLIST_ERC_ITEMS_PROVIDER errors( m_schematic.get() );
|
|
|
|
// Skip the "Modified symbol" warning
|
|
settings.m_ERCSeverities[ERCE_LIB_SYMBOL_ISSUES] = RPT_SEVERITY_IGNORE;
|
|
|
|
m_schematic->ConnectionGraph()->RunERC();
|
|
|
|
ERC_TESTER tester( m_schematic.get() );
|
|
tester.TestConflictingBusAliases();
|
|
tester.TestMultUnitPinConflicts();
|
|
tester.TestMultiunitFootprints();
|
|
tester.TestNoConnectPins();
|
|
tester.TestPinToPin();
|
|
tester.TestSimilarLabels();
|
|
|
|
errors.SetSeverities( RPT_SEVERITY_ERROR | RPT_SEVERITY_WARNING );
|
|
|
|
BOOST_CHECK_MESSAGE( errors.GetCount() == test.second,
|
|
"Expected " << test.second << " errors in " << test.first.ToStdString()
|
|
<< " but got " << errors.GetCount() );
|
|
}
|
|
}
|