mirror of
https://gitlab.com/kicad/code/kicad.git
synced 2025-09-15 10:43:15 +02:00
d30ac2967a
When parsing component names, we need to account for the possibility of illegal characters (e.g. "/", ":") in the names from v4 libraries. They are fixed internally by the cache parser but if we don't fix them in the rescue routine, the symbol won't match it's cache name. This standardizes all schematic illegal character routines into LIB_ID Fixes: lp:1774774 * https://bugs.launchpad.net/kicad/+bug/1774774
109 lines
3.5 KiB
C++
109 lines
3.5 KiB
C++
/*
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
*
|
|
* Copyright (C) 2007 Jean-Pierre Charras, jp.charras at wanadoo.fr
|
|
* Copyright (C) 2007-2017 KiCad Developers, see CHANGELOG.TXT for contributors.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, you may find one here:
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
*/
|
|
|
|
#include <fctsys.h>
|
|
#include <gr_basic.h>
|
|
#include <class_drawpanel.h>
|
|
#include <confirm.h>
|
|
|
|
#include <sch_component.h>
|
|
#include <lib_edit_frame.h>
|
|
#include <class_library.h>
|
|
#include <symbol_lib_table.h>
|
|
#include <template_fieldnames.h>
|
|
#include <dialog_edit_one_field.h>
|
|
|
|
#include <lib_manager.h>
|
|
#include <widgets/cmp_tree_pane.h>
|
|
#include <component_tree.h>
|
|
|
|
|
|
void LIB_EDIT_FRAME::EditField( LIB_FIELD* aField )
|
|
{
|
|
wxString newFieldValue;
|
|
wxString caption;
|
|
|
|
if( aField == NULL )
|
|
return;
|
|
|
|
LIB_PART* parent = aField->GetParent();
|
|
wxCHECK( parent, /* void */ );
|
|
|
|
// Editing the component value field is equivalent to creating a new component based
|
|
// on the current component. Set the dialog message to inform the user.
|
|
if( aField->GetId() == VALUE )
|
|
caption = _( "Component Name" );
|
|
else
|
|
caption.Printf( _( "Edit Field %s" ), GetChars( aField->GetName() ) );
|
|
|
|
DIALOG_LIB_EDIT_ONE_FIELD dlg( this, caption, aField );
|
|
|
|
// The dialog may invoke a kiway player for footprint fields
|
|
// so we must use a quasimodal dialog.
|
|
if( dlg.ShowQuasiModal() != wxID_OK )
|
|
return;
|
|
|
|
newFieldValue = dlg.GetText();
|
|
LIB_ID::FixIllegalChars( newFieldValue, LIB_ID::ID_SCH );
|
|
wxString oldFieldValue = aField->GetFullText( m_unit );
|
|
bool renamed = aField->GetId() == VALUE && newFieldValue != oldFieldValue;
|
|
|
|
if( renamed )
|
|
{
|
|
wxString msg;
|
|
wxString lib = GetCurLib();
|
|
|
|
// Test the current library for name conflicts
|
|
if( !lib.empty() && m_libMgr->PartExists( newFieldValue, lib ) )
|
|
{
|
|
msg.Printf( _(
|
|
"The name \"%s\" conflicts with an existing entry in the symbol library \"%s\"." ),
|
|
newFieldValue, lib );
|
|
|
|
DisplayErrorMessage( this, msg );
|
|
return;
|
|
}
|
|
|
|
SaveCopyInUndoList( parent, UR_LIB_RENAME );
|
|
parent->SetName( newFieldValue );
|
|
|
|
if( !parent->HasAlias( m_aliasName ) )
|
|
m_aliasName = newFieldValue;
|
|
|
|
m_libMgr->UpdatePartAfterRename( parent, oldFieldValue, lib );
|
|
|
|
// Reselect the renamed part
|
|
m_treePane->GetCmpTree()->SelectLibId( LIB_ID( lib, newFieldValue ) );
|
|
}
|
|
|
|
if( !aField->InEditMode() && !renamed )
|
|
SaveCopyInUndoList( parent );
|
|
|
|
dlg.UpdateField( aField );
|
|
m_canvas->Refresh();
|
|
|
|
OnModify();
|
|
UpdateAliasSelectList();
|
|
}
|