mirror of
https://gitlab.com/kicad/code/kicad.git
synced 2025-09-14 18:23:15 +02:00
This function attempted a poor-man's natural compare but it assumed specific structure of the string. This broke for strings with numberings that looked like decimals. Instead, we use our natural string comparison function and remove the references to this older function and its similar elements. Fixes https://gitlab.com/kicad/code/kicad/issues/9067
117 lines
3.9 KiB
C++
117 lines
3.9 KiB
C++
/*
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
*
|
|
* Copyright (C) 2018 KiCad Developers, see CHANGELOG.TXT for contributors.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, you may find one here:
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
*/
|
|
|
|
/**
|
|
* @file
|
|
* Test suite for general string functions
|
|
*/
|
|
|
|
#include <qa_utils/wx_utils/unit_test_utils.h>
|
|
|
|
// Code under test
|
|
#include <string_utils.h>
|
|
|
|
/**
|
|
* Declare the test suite
|
|
*/
|
|
BOOST_AUTO_TEST_SUITE( KicadString )
|
|
|
|
/**
|
|
* Test the #GetTrailingInt method.
|
|
*/
|
|
BOOST_AUTO_TEST_CASE( TrailingInt )
|
|
{
|
|
using CASE = std::pair<std::string, int>;
|
|
|
|
const std::vector<CASE> cases = {
|
|
{ "", 0 }, { "foo", 0 }, // no int
|
|
{ "0", 0 }, // only int
|
|
{ "42", 42 }, // only int
|
|
{ "1001", 1001 }, // only int
|
|
{ "Foo42", 42 }, { "12Foo42", 42 }, // only the trailing
|
|
{ "12Foo4.2", 2 }, // no dots
|
|
};
|
|
|
|
for( const auto& c : cases )
|
|
{
|
|
BOOST_CHECK_EQUAL( GetTrailingInt( c.first ), c.second );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Test the #StrNumCmp method.
|
|
*/
|
|
BOOST_AUTO_TEST_CASE( NaturalNumberCompare )
|
|
{
|
|
using CASE = std::pair<std::pair<std::string, std::string>, std::pair<int, int>>;
|
|
|
|
const std::vector<CASE> cases = {
|
|
{ { "a", "b" }, { -1, -1 } },
|
|
{ { "b", "a" }, { 1, 1 } },
|
|
{ { "a", "a" }, { 0, 0 } },
|
|
{ { "a", "A" }, { 1, 0 } },
|
|
{ { "A", "a" }, { -1, 0 } },
|
|
{ { "a", "" }, { 1, 1 } },
|
|
{ { "", "a" }, { -1, -1 } },
|
|
{ { "1", "" }, { 1, 1 } },
|
|
{ { "", "1" }, { -1, -1 } },
|
|
{ { "10", "2" }, { 1, 1 } },
|
|
{ { "2", "10" }, { -1, -1 } },
|
|
{ { "2", "2" }, { 0, 0 } },
|
|
{ { "10", "10" }, { 0, 0 } },
|
|
{ { "01", "1" }, { 0, 0 } },
|
|
{ { "01a", "1a" }, { 0, 0 } },
|
|
{ { "01a", "1b" }, { -1, -1 } },
|
|
{ { "01b", "1a" }, { 1, 1 } },
|
|
{ { "10 ten", "2 two" }, { 1, 1 } },
|
|
{ { "SYM1", "sym2" }, { -1, -1 } },
|
|
{ { "sym2", "SYM1" }, { 1, 1 } },
|
|
{ { "a10b20c30", "a10b20c31" }, { -1, -1 } },
|
|
{ { "a10b20c31", "a10b20c30" }, { 1, 1 } },
|
|
{ { "10UF", "10UF" }, { 0, 0 } },
|
|
{ { "10uF", "10uF" }, { 0, 0 } },
|
|
{ { "u10", "u10" }, { 0, 0 } },
|
|
{ { "U10", "U10" }, { 0, 0 } },
|
|
{ { "u10", "U10" }, { 1, 0 } },
|
|
{ { "U10", "u10" }, { -1, 0 } },
|
|
{ { "U10.1", "U10.10" }, { -1, -1 } },
|
|
{ { "U10-1", "U10-10" }, { -1, -1 } },
|
|
{ { "U10,1", "U10,10" }, { -1, -1 } },
|
|
{ { "U10.A", "U10.a" }, { -1, 0 } },
|
|
{ { "U10-A", "U10-a" }, { -1, 0 } },
|
|
{ { "U10,A", "U10,a" }, { -1, 0 } },
|
|
};
|
|
|
|
for( const auto& c : cases )
|
|
{
|
|
BOOST_CHECK_MESSAGE( StrNumCmp( c.first.first, c.first.second ) == c.second.first,
|
|
c.first.first + " AND " + c.first.second + " failed for case sensitive" );
|
|
|
|
BOOST_CHECK_MESSAGE(
|
|
StrNumCmp( c.first.first, c.first.second, true ) == c.second.second,
|
|
c.first.first + " AND " + c.first.second + " failed for case insensitive" );
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|