mirror of
https://gitlab.com/kicad/code/kicad.git
synced 2025-09-14 02:03:12 +02:00
8eca23aabe
The variable `m_Initialized` in `BASE_SCREEN` is used by `SCH_EDIT_FRAME` to mark whether a screen had its zoom level initialized by the "zoom to fit screen" action. When this variable is `false`, the function `SCH_EDIT_FRAME::DisplayCurrentSheet()` performs "zoom to fit screen", modifying the zoom level. This function is indirectly called in the undo routines, so if `m_Initialized` is not set to `true`, a zoom change will occur when the user undoes an operation, a behavior that is undesired. `m_Initialized` was not initialized to `true` for the null schematic (the schematic that is loaded if no project is loaded), causing the aforementioned undesired behavior. To prevent this, I've changed the `SCH_EDIT_FRAME` constructor to set `m_Initialized` to `true`, since it zooms to fit screen already. I've moved `m_Initialized` from `BASE_SCREEN` to `SCH_SCREEN`, as it is used only in Eeschema, and renamed it to `m_zoomInitialized`, a name I believe that better describes what this variable does. I've also introduced the function `SCH_EDIT_FRAME::initScreenZoom()` to group the "zoom to fit screen" action with setting `m_Initialized` to `true`, as they often should occur together. I'd also like to say that I'm not confident whether `SCH_EDIT_FRAME::DisplayCurrentSheet()` should perform the zoom level initialization at this point, but I have decided to not change this behavior for now, as the commit history suggests it's several years old. Fixes https://gitlab.com/kicad/code/kicad/issues/7343
102 lines
2.9 KiB
C++
102 lines
2.9 KiB
C++
/*
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
*
|
|
* Copyright (C) 2012 Jean-Pierre Charras, jean-pierre.charras@ujf-grenoble.fr
|
|
* Copyright (C) 2012 SoftPLC Corporation, Dick Hollenbeck <dick@softplc.com>
|
|
* Copyright (C) 2012 Wayne Stambaugh <stambaughw@gmail.com>
|
|
* Copyright (C) 1992-2020 KiCad Developers, see AUTHORS.txt for contributors.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, you may find one here:
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
*/
|
|
|
|
#include <base_screen.h>
|
|
#include <eda_item.h>
|
|
#include <trace_helpers.h>
|
|
|
|
|
|
wxString BASE_SCREEN::m_PageLayoutDescrFileName; // the name of the page layout descr file.
|
|
|
|
|
|
BASE_SCREEN::BASE_SCREEN( EDA_ITEM* aParent, KICAD_T aType ) :
|
|
EDA_ITEM( aParent, aType )
|
|
{
|
|
m_virtualPageNumber = 1;
|
|
m_pageCount = 1; // Hierarchy: Root: ScreenNumber = 1
|
|
m_Center = true;
|
|
|
|
m_flagModified = false; // Set when any change is made on board.
|
|
m_flagSave = false; // Used in auto save set when an auto save is required.
|
|
}
|
|
|
|
|
|
void BASE_SCREEN::InitDataPoints( const wxSize& aPageSizeIU )
|
|
{
|
|
if( m_Center )
|
|
{
|
|
m_crossHairPosition.x = 0;
|
|
m_crossHairPosition.y = 0;
|
|
|
|
m_DrawOrg.x = -aPageSizeIU.x / 2;
|
|
m_DrawOrg.y = -aPageSizeIU.y / 2;
|
|
}
|
|
else
|
|
{
|
|
m_crossHairPosition.x = aPageSizeIU.x / 2;
|
|
m_crossHairPosition.y = aPageSizeIU.y / 2;
|
|
|
|
m_DrawOrg.x = 0;
|
|
m_DrawOrg.y = 0;
|
|
}
|
|
|
|
m_LocalOrigin = { 0, 0 };
|
|
}
|
|
|
|
|
|
void BASE_SCREEN::SetPageCount( int aPageCount )
|
|
{
|
|
wxCHECK( aPageCount > 0, /* void */ );
|
|
|
|
m_pageCount = aPageCount;
|
|
}
|
|
|
|
|
|
const wxString& BASE_SCREEN::GetPageNumber() const
|
|
{
|
|
static wxString pageNumber;
|
|
|
|
if( m_pageNumber.IsEmpty() )
|
|
pageNumber.Printf( "%d", m_virtualPageNumber );
|
|
else
|
|
pageNumber = m_pageNumber;
|
|
|
|
return pageNumber;
|
|
}
|
|
|
|
|
|
#if defined(DEBUG)
|
|
|
|
void BASE_SCREEN::Show( int nestLevel, std::ostream& os ) const
|
|
{
|
|
// for now, make it look like XML, expand on this later.
|
|
NestedSpace( nestLevel, os ) << '<' << GetClass().Lower().mb_str() << ">\n";
|
|
|
|
NestedSpace( nestLevel, os ) << "</" << GetClass().Lower().mb_str() << ">\n";
|
|
}
|
|
|
|
#endif
|