The iterator changes when you modify the list, leading to unpredictable
results. Using the count, working from the back ensures that our list
is stable when removing fields.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19672
Otherwise, stright lines have no shadow at all. The alternative is
to special case stright lines, which means that some graphics
get stroke shadows and some don't and it looks inconsistent.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/19662
(They'll just point to temp files anyway.)
Also moves schematic netlist fetching to
MAIL_SCH_GET_NETLIST.
Eeschema's generateSchematicNetlist() hasn't
worked in some time.
Also suppresses parity error counts when parity
not run due to failure to find or load schematic.
Also writes out ERC/DRC reports even when they're
set to fail the job.
Also improves adding/removing netlist exporters to
select an appropriate tab in the dialog (either
the newly-created one or the one preceeding the
deleted one).
(They'll just point to temp files anyway.)
Also moves schematic netlist fetching to
MAIL_SCH_GET_NETLIST.
Eeschema's generateSchematicNetlist() hasn't
worked in some time.
Also suppresses parity error counts when parity
not run due to failure to find or load schematic.
Also writes out ERC/DRC reports even when they're
set to fail the job.
There are two netclass name methods, which previously were not
obvious in their uses. These have been renamed to now have:
GetName() : Used for internal or tooling (e.g. netlist export) usage
GetHumanReadableName() : Used for display to users (e.g. in infobars)
Fixing the previous unclear naming will result in fewer bugs
when users start using the multiple netclass functionality, as
the incorrect usage had started creeping in to new code. Also this
will help authors of new code select the correct name method.
Cloning the item into the previewe means that if we later increment
it, the preview clone doesn't update. Use the non-owning preview
interface to use the item directly in the preview.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/19433
When the user is navigating a drop down menu, they don't want the
preview window to pop over their screen. This glues between the
LIB_TREE and the frame to block these preview events
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19117
If a sheet is bigger than the page size selected in the plotter (PC, PDF , SVG)
(i.a a A3 sheet plotted scaled to A4 page) the background area size actually plotted
was to small.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19611
If the sim hasn't run, we don't have data and ngspice will complain.
It's a harmless message but new users don't know this and it sounds
problematic.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19600
This icon was only used for auto-starting a wire, which was
inconsistent with auto-starting a bus or graphic line.
Also the plus sign is a little confusing as it could also be
interpreted as the origin marker (which is really bottom left),
which is also plus-shaped.
