6 Commits

Author	SHA1	Message	Date
Seth Hillbrand	b5f021ff9f	Cleanup: Replace push_back with emplace_back ... In cases where we create a new item and immediately push into a container, the emplace idiom is faster and more efficient.	2019-12-05 13:41:21 -08:00
John Beard	371149756d	QA: Remove expected failure from fixed tests ... Commit 55fcbddde8205acb9832ccd5fc441b70ff6f537e fixed a couple of failures in the SHAPE_POLY_SET tests, so these no longer need the expected failure markers.	2019-04-17 11:47:42 +01:00
Seth Hillbrand	2a00fc962b	Fix error in contour check ... Correct mistake in bool() that prevented checking correct contour for end of vertex list.	2019-04-16 20:21:04 -07:00
John Beard	8e75f6029c	QA: Mark failing SHAPE_POLY_SET tests as expected failures ... This allows the tests to remain sensitive to other errors. When SHAPE_POLY_SET is fixed, these expected failures should be removed.	2019-01-30 11:55:10 +01:00
John Beard	55fcbddde8	QA: Fix faulty test of SHAPE_POLY_SET Collision ... This test assumed points on a edge are counted as colliding. This is not true: points on an edge are NOT counted at inside the poly_set. THe test does still consider points on a *hole* edge as collisions. The API to SHAPE_POLY_SET is unclear on if this is correct.	2019-01-29 18:06:16 -05:00
John Beard	11745f8f44	QA: Move contents qa_shape_poly_set_refactor to qa_common ... The "refactor" element of qa_shape_poly_set_refactor has been previously removed, so these tests are now just regular tests on libcommon classes. These can therefore be moved to qa_common and the qa_shape_poly_set_refactor unit test suit can finally be totally removed.	2019-01-29 08:15:44 -05:00