realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-15 02:33:15 +02:00
Code Issues Packages Projects Releases Wiki Activity
41,943 Commits 11 Branches 130 Tags
Commit Graph

697 Commits

Author SHA1 Message Date
Jeff Young
7ed5963b4f Disable positioning tools when a move is in progress. 
Also fixes a typo in EDIT_TOOL::doMoveSelection().

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15090
 2023-06-30 20:37:03 +01:00
Jeff Young
773e1a1ab6 Actions with a COMMIT must be run synchronously. 
Note that "immediate" doesn't mean quite the same thing: while it will
enter the tool immediately, it won't necessarily finish the tool during
the call if the tool has an event loop.  So for something like Rotate
"immediate" and "synchronous" have the same behaviour, but for something
like Move they do not.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15085
 2023-06-30 18:57:37 +01:00
Jeff Young
1411b09178 Remove EDIT_TOOL's quasi-global BOARD_COMMIT. 
It had several encapsulation leakage issues, as well as poorly-defined
behaviour of undo for chained-actions (append-to-board, and then rotate
while moving, for instance).
 2023-06-27 17:04:18 +01:00
Ian McInerney
2fb6f19a84 Separate immediate and delayed action dispatch 
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
 2023-06-27 00:57:59 +01:00
Jeff Young
493828cc6b Eradicate a bunch of calls to dyn_cast. 
Also deletes PAD::GetParent() which fails to look for parent footprint
through groups.
 2023-06-25 11:10:07 +01:00
Ian McInerney
f14feafc6b Convert selection vector to EDA_ITEMS for base tool call 
The base tool expects a generic EDA_ITEMS, but the existing vector
doesn't easily cast, so add a temporary one.
 2023-06-20 21:52:50 +01:00
Ian McInerney
f899d9676f Remove unneeded parameter from tool call 2023-06-20 21:52:50 +01:00
Ian McInerney
480223f67c More RunAction specialization 2023-06-20 21:52:50 +01:00
Ian McInerney
07cc85e76c Fix more places where casts into RunAction were happening 2023-06-20 21:52:50 +01:00
Ian McInerney
b04e54dbea Switch TOOL_EVENT and TOOL_ACTION to have a std::any parameter 
Using std::any from C++17 allows for proper type handling in the
parameter field, removing the need for casting to void* and then casting
the void* to the desired type.
 2023-06-20 21:52:50 +01:00
Mike Williams
6d93950dcc PCB: abolish TEXT_TYPE::TEXT_is_* 
PCB_TEXT is now always what was formerly TEXT_is_DIVERS and PCB_FIELDs
now what mandatory field type they are already.
 2023-06-20 18:34:52 +00:00
Mike Williams
37837dc392 PCB: introduce PCB_FIELD_T 2023-06-20 18:34:52 +00:00
Jeff Young
30336b2fe3 Unify go-back-one-step processing for drawing tools (and router). 
Also warps mouse on all go-back-one-step operations for better feedback.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14981

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9985
 2023-06-19 17:14:32 +01:00
Jeff Young
96a221ceba Refresh delete immediately; don't wait for next mouse motion. 2023-06-10 21:11:05 +01:00
Jeff Young
2ac3f4cc9e Undo strategy based on being in a footprint, not footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14799
 2023-05-23 17:56:12 +01:00
Mike Williams
04a53ea40d Picker Tools: make sure we know what tool we are 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14621
 2023-05-01 12:43:09 -04:00
Jeff Young
28028c941e Retire Local/Draw coords distinction from PAD (the last object to have it). 2023-04-02 18:02:41 +01:00
jean-pierre charras
054de5687c Pcbnew: fix crash when trying to delete a PCB_TEXT. 2023-04-02 12:15:18 +02:00
Jeff Young
bbd6c80507 Collapse FP_* down into their PCB_* equivalents. 2023-03-31 22:57:46 +01:00
jean-pierre charras
f8051d954a Better handling of PCB_BITMAP items in a footprint. 
- Ensure they can be erased in the FP editor
- Ensure they cannot be selected in the PCB editor (they are not show)
Fixes #13714
https://gitlab.com/kicad/code/kicad/issues/
 2023-01-31 11:16:38 +01:00
Mike Williams
b8352b07c5 PCB: Immediate mode copy should deselect if hover selecting 2023-01-19 09:45:47 -05:00
jean-pierre charras
07b4f88e6b Pcbnew: Fillet Lines tool does not set line width and layer. 
When fillet a polygon or a rect, the resulting lines and arcs had incorrect
width and layer.
Fixes #13338
https://gitlab.com/kicad/code/kicad/issues/13338
 2023-01-02 16:52:08 +01:00
Mike Williams
741d1e043a PCB Editor: make Mirror menu items conditional 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13230
 2022-12-27 14:18:47 -05:00
Jeff Young
1f3727f548 Assigning a netclass has no meaning in fp editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13267
 2022-12-26 20:33:04 +00:00
jean-pierre charras
44ab6876d9 fp editor: remove useless "Unroute Selected" from context menu. 
Fixes #13229
https://gitlab.com/kicad/code/kicad/issues/13229
 2022-12-21 13:11:51 +01:00
Mike Williams
bd24e85289 PCB: Add Copy With Reference to the Positioning Menu 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11947
 2022-12-20 11:54:05 -05:00
Mike Williams
17bb57cc73 PCB: fix stale ratsnest between moves in Move Individually 2022-11-30 09:11:37 -05:00
Mike Williams
ad6ef35c9f PCB: Add skip action to Move Individually 2022-11-29 15:42:03 +00:00
Mike Williams
3042633f4a PCB: block unroute and move individually when already moving 2022-11-28 14:16:08 -05:00
Seth Hillbrand
01138a2e19 Fix fillet action for lines 
Generalize fillet action behavior to all straight lines in pcbnew

Fixes https://gitlab.com/kicad/code/kicad/issues/4742
 2022-11-21 07:01:14 -08:00
Jeff Young
7089e99f4b Integrate move individually into move algo so other commands don't choke. 
Also adds commands to cancel and finish move individually.

Fixes https://gitlab.com/kicad/code/kicad/issues/12750

Fixes https://gitlab.com/kicad/code/kicad/issues/12749
 2022-11-13 13:18:42 +00:00
Jeff Young
03ba14c6d3 Tighten lifecycle management of parent group pointers. 
Also adds some debugging to try to catch dangling pointers.

Also adds a cache for group bounding boxes (which will be expensive
to calculate for large groups).

Fixes https://gitlab.com/kicad/code/kicad/issues/12875
 2022-11-11 17:27:28 +00:00
Jeff Young
ae741b93e6 Resore push/pop-less PickerTool. 
(Functionality was accidentallly lost when we removed the opt command
strings.)
 2022-11-07 19:11:12 +00:00
Jeff Young
3b3e6de515 Disable mirror commands when a single footprint is selected. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12752
 2022-10-28 19:20:24 +01:00
Jeff Young
46752499df We need both a tool-oriented delete and one that doesn't push/pop, etc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12600
 2022-10-17 13:21:07 +01:00
Alex
4095172259 ADDED: Pack and Move Footprints, improved footprint spread algorithm. 2022-09-28 13:37:23 +00:00
Jeff Young
3a7068b346 Iterate on a copy of the selection since we're going to delete from it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12484
 2022-09-27 23:54:19 +01:00
Mike Williams
e66393c4dd PCB Tools: Move Individually 
Allows moving a selection of components one by one.
 2022-09-26 16:17:41 -04:00
Jeff Young
7e71dc084c Implement Mirror H/V for tracks and vias. 
While not that often useful, it's really annoying that it doesn't work
when you *do* find a use-case for it.

Fixes https://gitlab.com/kicad/code/kicad/issues/6853
 2022-09-24 19:55:48 +01:00
Jeff Young
897135a4f0 Support mirroring on the board too. 
Also fixes a few bugs in FP item mirroring.

Fixes https://gitlab.com/kicad/code/kicad/issues/2168
 2022-09-22 15:05:58 +01:00
Jeff Young
513fc872bb Support both X and Y mirroring in FPEditor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12409
 2022-09-21 00:16:27 +01:00
Mike Williams
ca0c9f12e0 PCB Editor: Unroute Footprint 
Also works on selected pads.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/1955
 2022-09-19 10:37:10 -04:00
Mike Williams
9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Marek Roszko
3d5913c825 Remove convert_to_biu.h, merge contents to base_units.h 2022-09-16 21:09:28 -04:00
Marek Roszko
66e8931405 Remove IU_PER_MM thats standalone 2022-09-16 21:09:27 -04:00
Marek Roszko
a8613ee80f Combine Iu2Millimeter & remove PcbMm2iu 2022-09-16 21:09:26 -04:00
Jeff Young
107f409106 Use router's connectivity algorithm, not CONNECTIVITY_DATA's. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-16 22:49:20 +01:00
Mark Roszko
b00178adb3 Nuke base_units from orbit 2022-09-16 04:38:10 +00:00
Mike Williams
de6e368ac6 PCB: Swap Tool 2022-09-12 09:39:43 -04:00
Jeff Young
9cf3c529d3 Apply the same accuracy band to connectivity as we use for hittesting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-09 21:42:21 +01:00