12170 Commits

Author SHA1 Message Date
Jon Evans
5b88f2509e Use stable sort ordering in ERC reports
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20333


(cherry picked from commit fe22166d9f0da180c8ac645397fe663759147d6a)

Co-authored-by: Jon Evans <jon@craftyjon.com>
2025-03-16 11:22:06 -04:00
Graham Keeth
b5716ef54b improve tooltips in sync sheet pins dialog
(cherry picked from commit 89a5fadcdcc62a9a2691e0130e20f9802c30b846)
2025-03-14 16:55:24 -07:00
Graham Keeth
9515bf9038 Add ellipses for sheet/sheet pin actions
(cherry picked from commit c57088a60cb8db14c1e29c2993961fe616243572)
2025-03-14 16:55:05 -07:00
Seth Hillbrand
49d8fc900f Map a full hierarchy during PDF plotting
Re-create the schematic hierarchy in PDF plots to ease navigation
relative to the on screen schematic

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12154

(cherry picked from commit 4a3b33df4e8a95ce3cafe8dc810642501f929d72)
2025-03-14 16:51:18 -07:00
JamesJCode
27b55eb32f Include child SCH_PINs in SCH_RULE_AREA item caches
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20332

(cherry picked from commit 078a01976f988a64a83631a80ffa21fcbf7fc462)
2025-03-14 20:58:15 +00:00
Jeff Young
3ea0191954 Init checkboxes after reading prefs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20309

(cherry picked from commit 521b411090d7ddc360b04a59cc0d808921d7bd54)
2025-03-14 14:52:04 +00:00
Jon Evans
f835591c8b Simulator: Fix line offset in intermediate ngspice file
- Fixes issue #20268
- Replace the hard coded line numbers
- Search for "Value:" string instead


(cherry picked from commit 313232c9f3c241dc7edb35823fb9e9360ba3d164)

Co-authored-by: Lucas Gerads <lucas.gerads@aixcon.de>
2025-03-13 18:30:24 -04:00
Jeff Young
ff578d9866 De-duplicate table border drawing code.
Also cleans up a misconception about table header borders,
and renames the getter/setter to be clearer.

Also makes sure that table cells are updated when the table
layer changes.

And another bug where we were writing the grey color value
back to the cell for hidden cells.
2025-03-13 13:08:30 +00:00
Jeff Young
48e254fe4c EE -> SCH (no functional changes) 2025-03-13 12:28:25 +00:00
jean-pierre charras
10d34f5b9b Eeschema printing: ensure the flag "is first page" is correctly set.
It is mainly used to draw page layouts having different objects drawn on
first page and other pages.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/20318

(cherry picked from commit ddd27f286934e69bf6fb862c870250c0c5cbc726)
2025-03-13 11:36:07 +01:00
Jeff Young
4b26e737c0 Don't wait for mouse move to draw selection shadows.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20309
2025-03-12 09:39:03 +00:00
Jon Evans
028721f3ed Don't use size events for persistence
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20060


(cherry picked from commit 95e6ca44c6d28af670a59fc5f451a9a6ebfc9bc4)

Co-authored-by: Jon Evans <jon@craftyjon.com>
2025-03-11 22:37:29 -04:00
Seth Hillbrand
1effbe5d01 Prevent ERC error with NC pin+NC marker
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20222

(cherry picked from commit 4f6a73d83c018891892f522d434c18e9f8788710)
2025-03-07 15:26:06 -08:00
Seth Hillbrand
50711b1294 Revert "Allow a no-connect to connect to a single pin (but not multiple pins)."
This reverts commit ee4a6127c6bed91f0d153983b8dc88da1e3375f1.

(cherry picked from commit 2b557c5497abde6c078b6037671b115f12d11500)
2025-03-07 15:25:53 -08:00
Jeff Young
1de9a83ff0 Printing is not zoom-specific.
(Some of these items don't currently get printed, but
there's no sense in leaving a latent bug around in case
we ever change our minds.)

(cherry picked from commit 877c6bce8938e9ca6e3d3c6381a5dd5d9acfb9a4)
2025-03-07 19:00:10 +00:00
Seth Hillbrand
4df101b94e Ensure imported schematic sheet names are unique
Altium doesn't require sheet names to be unique but KiCad does, so we
disambiguate the names when importing

Fixes https://gitlab.com/kicad/code/kicad/-/issues/19281

(cherry picked from commit ca51b0f37ddbaf2f285b6a17833ac4fb340e8490)
2025-03-06 16:10:08 -08:00
Seth Hillbrand
cf78215276 Fix multi-unit symbol import in Altium sch
Set the library symbol equal to total unit count so that we can assign
elements to the correct unit in the SCH_SYMBOL

(cherry picked from commit 81fcc16cc9c15dbc3f03af59a42535c75f720dcf)
2025-03-06 15:20:44 -08:00
jean-pierre charras
58422f2c97 SCH_IO_MGR::GuessPluginTypeFromLibPath(): fix issue for new .kicad_sym files
GuessPluginTypeFromLibPath() was previously testing the type, but also the
existence of the lib file of *.kicad_sym filename, but when creating a new lib,
its existence obviously must not be tested

(cherry picked from commit e54c73b516b874e577c69daaf554819a6d5c0383)
2025-03-06 18:12:27 +01:00
Jeff Young
618077bbf2 Resolve hotkey conflicts.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18201
2025-03-06 16:15:23 +00:00
Jeff Young
12f460cc7a Don't treat version-bumped file as modified.
But do allow Save to still work.

(cherry picked from commit 5c91a7fa3a2f6b3972b4c7333f1e43521e645653)
2025-03-06 16:15:23 +00:00
Jeff Young
759b279009 Allow a no-connect to connect to a single pin (but not multiple pins).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20222
2025-03-06 10:26:30 +00:00
Jeff Young
456fc581f1 Don't flag double no-connect annotations.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20222
2025-03-06 10:26:30 +00:00
Jeff Young
91a2edd16f Don't add CONSTRUCTION_GEOM to the selection.
We'll crash later after it gets freed.
2025-03-04 14:13:26 +00:00
Jeff Young
765c4ffce6 Report errors from jobset plotting.
Also fixes an out-of-scope smart-pointer access.
2025-03-04 13:26:04 +00:00
Jeff Young
d033859596 Handle exporting symbols into libraries already under LIB_MGR.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17840

(cherry picked from commit afa4ebcc846facae098762ecb5af4e5ee6a97f1c)
2025-03-03 16:13:40 +00:00
Jeff Young
c7a6f3c63b Restore "Export Symbol".
The workflow turns out to be slightly different
than a Save As to a new library.

(We don't assume it goes in a library table; we
flatten the symbol; and we pre-load the library
name.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/20070

(cherry picked from commit 6b146874c164bbfa505fe4a633988c183ba1db70)
2025-03-03 16:13:40 +00:00
Jeff Young
984b872c28 Formatting.
(cherry picked from commit 1c48e97cd72a981f5a16ebb3f8234f22fea2e976)
2025-03-03 16:13:40 +00:00
jean-pierre charras
2504195e6e Fix a collision with a Windows define and our use of the same var name.
We use IN for INCH as units, but IN is defined in a Windows header

(cherry picked from commit b0fe4df3c565027801cbbac56c6ee0da254bd74a)
(cherry picked from commit 0acdabd1eb1a2d5ab9b6aa9f71df31c8cf088de8)
(cherry picked from commit eaa1e6d59464e8356d24afd1d29148335010f67a)
2025-03-02 16:13:11 +01:00
Jeff Young
31fe178504 Don't generate -1 width non-filled splines.
They serve no purpose, and will get replaced with
default-line-width non-filled splines.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/20138
2025-03-02 11:33:34 +00:00
Jeff Young
203ddb7b47 Code brevity.
(cherry picked from commit f951497a4fdf47e7c839f71df7a1b06660540ec9)
2025-03-01 22:23:30 +00:00
Jeff Young
0ec82b65be Formatting; code brevity.
(cherry picked from commit 481e46796809cdef9db5388cc765d4fb3ea4b8ac)
2025-03-01 22:18:35 +00:00
Jon Evans
5c624dacd2 Fix SCH_SHEET field layer settings
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20128

(cherry picked from commit 10cb0592ee859fa81a98f2739f54acd23289435c)
2025-03-01 11:32:04 -05:00
Jon Evans
41c3607512 Fix 9.0 formatting of fields
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20166
2025-03-01 08:53:32 -05:00
Jeff Young
3a91fc8c2b Apply EEschema fixes to PCBNew and Footprint Editor.
(Symbol Editor doesn't have the issue of the properties
being overwritten.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/20066

(cherry picked from commit 797de67c6c21d6295e32c340a4eca97685fa370a)
2025-02-27 17:51:34 +00:00
Wayne Stambaugh
5cdca70bf1 Show the correct footprint name on footprint filter mismatch ERC warning.
The lower case variant used for internal comparison was being used which
is confusing because it doesn't match the footprint name capitalization.

(cherry picked from commit a9cea9fbb76b5a1eff39b1ed88f8c14e338447f3)
2025-02-27 09:54:06 -05:00
jean-pierre charras
1c0769ce27 Eeschema: fix incorrect plot of SCH_TABLE items.
(cherry picked from commit ba85c54f81ce52d42be5251d90b3a7ce7079f4e7)
2025-02-27 14:12:08 +01:00
Jon Evans
798e9999c2 Add missing change from previous commit
See b6aac93


(cherry picked from commit de160e4af66514822768e3db636ee7a0edb88269)

Co-authored-by: Jon Evans <jon@craftyjon.com>
2025-02-26 04:42:19 +00:00
Jeff Young
a3e3c0384e Mirror location of textbox.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20021
2025-02-23 22:08:48 +00:00
Jeff Young
6485465301 Fix plot dialog layout. 2025-02-23 22:08:48 +00:00
Seth Hillbrand
b135491d35 Allow sim models to reference embedded files
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20024

(cherry picked from commit 157c7422b08ea7572c36c354e37643ab97c7c102)
2025-02-22 14:54:38 -08:00
Seth Hillbrand
a844554443 Quiet down the Exclude from Sim marks in Schematic
The big grey X and dimming the component made it look like the component
was no longer a part of the circuit, rather than just being excluded for
a single purpose.

The changes the display to make a more subtle grey outline with an icon
in the corner to indicate that this refers to simulation.

(cherry picked from commit 878cf768d6552131494aa792dc20e6ccf67baf75)
2025-02-22 13:01:16 -08:00
Seth Hillbrand
c4c32aa7bb Prevent crash when importing over existing project
If the hierarchy navigator is open and expanded, we have references to
the existing sheets.  These need to be cleared when importing a new
sheet over top

Fixes https://gitlab.com/kicad/code/kicad/-/issues/20004

(cherry picked from commit 2e93fb7a2440003373a184bba10bf133189eaad6)
2025-02-21 10:34:53 -08:00
Jeff Young
ba2156a0f1 parseMaybeAbsentBool's param is the naked token value, not the absent value.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20017
2025-02-21 11:17:03 +00:00
Jeff Young
ff3687420f Write hide flag at 9.0 level (inside effects). 2025-02-20 18:10:23 +00:00
Jeff Young
4e7da6169d Remove prohibition from clearing Value field in Symbol Fields Table.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19745

(cherry picked from commit fea659a00221b8754aff5f4bb69b050495537876)
2025-02-20 13:49:23 +00:00
Jeff Young
ebb8682dde Don't special case output directory label for jobsets.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19868

(cherry picked from commit be58dddcab1281e93a65ff01c5cbb936f52f9a4a)
2025-02-20 13:49:17 +00:00
Jeff Young
1b6621d898 Save copy of AUI config before applying it.
(It's going to do a bunch config saves, which
will otherwise overwrite all the user's preferences
with the defaults.)

(cherry picked from commit 006d8b290a2d66411fd6cbd614892acd10c750a3)
2025-02-20 13:47:46 +00:00
Jeff Young
b81f0b4377 Pretty-print cross references in Symbol Fields Table.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19941

(cherry picked from commit f65d2609618c7d5c55ee69a770fbcd1cdbfa02e3)
2025-02-20 13:46:22 +00:00
Jeff Young
f45e2b2252 Switch to using unit names in property inspector.
(cherry picked from commit d921a4e916d0389524f4b372ad787abc3d1a229f)
2025-02-20 13:37:37 +00:00
Jeff Young
db44690460 Update instance reference from property inspector.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19932

(cherry picked from commit 56b8fec74b2fc05dcf18192c3764ba0307f25666)
2025-02-20 13:37:33 +00:00