realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix logic error in checking IsErrorLimitExceeded().

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20671
This commit is contained in:
Jeff Young 2025-04-16 13:02:28 +01:00
parent 5279cc8767
commit f66f2e522f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pcbnew/drc/drc_test_provider_silk_clearance.cpp
View File

@ -84,7 +84,7 @@ bool DRC_TEST_PROVIDER_SILK_CLEARANCE::Run()
bool checkIndividualMaskItems = m_board->GetDesignSettings().m_SolderMaskMinWidth <= 0;
if( m_drcEngine->IsErrorLimitExceeded( DRCE_OVERLAPPING_SILK )
&& ( m_drcEngine->IsErrorLimitExceeded( DRCE_SILK_MASK_CLEARANCE) || !checkIndividualMaskItems ) )
&& m_drcEngine->IsErrorLimitExceeded( DRCE_SILK_MASK_CLEARANCE) )
{
return true; // continue with other tests
}
@ -188,8 +188,8 @@ bool DRC_TEST_PROVIDER_SILK_CLEARANCE::Run()
std::shared_ptr<SHAPE> hole;
if( ( m_drcEngine->IsErrorLimitExceeded( DRCE_SILK_MASK_CLEARANCE) || !checkIndividualMaskItems )
&& m_drcEngine->IsErrorLimitExceeded( DRCE_OVERLAPPING_SILK ) )
if( m_drcEngine->IsErrorLimitExceeded( DRCE_OVERLAPPING_SILK )
&& m_drcEngine->IsErrorLimitExceeded( DRCE_SILK_MASK_CLEARANCE ) )
{
return false;
}
@ -226,7 +226,7 @@ bool DRC_TEST_PROVIDER_SILK_CLEARANCE::Run()
errorCode = DRCE_SILK_MASK_CLEARANCE;
}
if( minClearance < 0 )
if( minClearance < 0 || m_drcEngine->IsErrorLimitExceeded( errorCode ) )
return true;
int actual;