realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 10:13:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't attempt to rename field more than once.

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18330
This commit is contained in:
Jeff Young 2024-07-07 11:55:04 +01:00
parent 1f18cc8e0e
commit e9d376c912
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eeschema/fields_data_model.cpp
View File

@ -84,10 +84,13 @@ void FIELDS_EDITOR_GRID_DATA_MODEL::RenameColumn( int aCol, const wxString& newN
{ {
SCH_SYMBOL* symbol = m_symbolsList[i].GetSymbol(); SCH_SYMBOL* symbol = m_symbolsList[i].GetSymbol();
auto node = m_dataStore[symbol->m_Uuid].extract( m_cols[aCol].m_fieldName ); // Careful; field may have already been renamed from another sheet instance
if( auto node = m_dataStore[symbol->m_Uuid].extract( m_cols[aCol].m_fieldName ) )
{
node.key() = newName; node.key() = newName;
m_dataStore[symbol->m_Uuid].insert( std::move( node ) ); m_dataStore[symbol->m_Uuid].insert( std::move( node ) );
} }
}
m_cols[aCol].m_fieldName = newName; m_cols[aCol].m_fieldName = newName;
m_cols[aCol].m_label = newName; m_cols[aCol].m_label = newName;