realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't set m_IsPreviewer to force 3D models.

Browse Source 
It has unintended side-effects (such as showing
user drawings and user comments layers).

Fixes https://gitlab.com/kicad/code/kicad/-/issues/21428
This commit is contained in:
Jeff Young 2025-08-06 11:21:01 +01:00
parent ece58909ba
commit b2ecaf1ddc
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pcbnew/pcbnew_jobs_handler.cpp
View File

@ -655,9 +655,6 @@ int PCBNEW_JOBS_HANDLER::JobExportRender( JOB* aJob )
boardAdapter.SetBoard( brd );
boardAdapter.m_IsBoardView = false;
if( aRenderJob->m_appearancePreset.empty() )
boardAdapter.m_IsPreviewer = true; // Force display 3D models, regardless of 3D viewer options
EDA_3D_VIEWER_SETTINGS cfg;
if( EDA_3D_VIEWER_SETTINGS* userCfg = GetAppSettings<EDA_3D_VIEWER_SETTINGS>( "3d_viewer" ) )
@ -667,6 +664,16 @@ int PCBNEW_JOBS_HANDLER::JobExportRender( JOB* aJob )
cfg.m_LayerPresets = userCfg->m_LayerPresets;
}
if( aRenderJob->m_appearancePreset.empty() )
{
// Force display 3D models
cfg.m_Render.show_footprints_not_in_posfile = true;
cfg.m_Render.show_footprints_dnp = true;
cfg.m_Render.show_footprints_insert = true;
cfg.m_Render.show_footprints_normal = true;
cfg.m_Render.show_footprints_virtual = true;
}
if( aRenderJob->m_quality == JOB_PCB_RENDER::QUALITY::BASIC )
{
// Silkscreen is pixelated without antialiasing