realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 18:23:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add advance config variable to skip bounding box loading on footprints

Browse Source
This commit is contained in:
Marek Roszko 2020-10-02 21:58:24 -04:00 committed by Seth Hillbrand
parent bb753aaadf
commit 9e115a548e
3 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/advanced_config.cpp
View File

@ -140,6 +140,8 @@ static const wxChar MinPlotPenWidth[] = wxT( "MinPlotPenWidth" );
static const wxChar DebugZoneFiller[] = wxT( "DebugZoneFiller" ); static const wxChar DebugZoneFiller[] = wxT( "DebugZoneFiller" );
static const wxChar SkipBoundingBoxFpLoad[] = wxT( "SkipBoundingBoxFpLoad" );
} // namespace KEYS } // namespace KEYS
@ -237,6 +239,8 @@ ADVANCED_CFG::ADVANCED_CFG()
m_DebugZoneFiller = false; m_DebugZoneFiller = false;
m_SkipBoundingBoxOnFpLoad = false;
loadFromConfigFile(); loadFromConfigFile();
} }
@ -314,6 +318,9 @@ void ADVANCED_CFG::loadSettings( wxConfigBase& aCfg )
configParams.push_back( new PARAM_CFG_BOOL( true, AC_KEYS::DebugZoneFiller, configParams.push_back( new PARAM_CFG_BOOL( true, AC_KEYS::DebugZoneFiller,
&m_DebugZoneFiller, false ) ); &m_DebugZoneFiller, false ) );
configParams.push_back( new PARAM_CFG_BOOL( true, AC_KEYS::SkipBoundingBoxFpLoad,
&m_SkipBoundingBoxOnFpLoad, false ) );
wxConfigLoadSetups( &aCfg, configParams ); wxConfigLoadSetups( &aCfg, configParams );
for( PARAM_CFG* param : configParams ) for( PARAM_CFG* param : configParams )

5
include/advanced_config.h
View File

@ -142,6 +142,11 @@ public:
*/ */
bool m_DebugZoneFiller; bool m_DebugZoneFiller;
/**
* Skip bounding box calculation when loading footprints
*/
bool m_SkipBoundingBoxOnFpLoad;
private: private:
ADVANCED_CFG(); ADVANCED_CFG();

12
pcbnew/pcb_parser.cpp
View File

@ -34,6 +34,7 @@
#include <title_block.h> #include <title_block.h>
#include <trigo.h> #include <trigo.h>
#include <advanced_config.h>
#include <class_board.h> #include <class_board.h>
#include <class_dimension.h> #include <class_dimension.h>
#include <class_drawsegment.h> #include <class_drawsegment.h>
@ -3083,7 +3084,16 @@ MODULE* PCB_PARSER::parseMODULE_unchecked( wxArrayString* aInitialComments )
module->SetFPID( fpid ); module->SetFPID( fpid );
module->SetProperties( properties ); module->SetProperties( properties );
module->CalculateBoundingBox();
// We want to calculate the bounding box in most cases except
// if the advanced config is set and its a general footprint load
// This improves debugging greatly under MSVC where full std iterator debugging
// is present and loading a massive amount of footprints can lead to 2 minute load times
if( !ADVANCED_CFG::GetCfg().m_SkipBoundingBoxOnFpLoad || m_board != nullptr
|| reader->GetSource().Contains( "clipboard" ) )
{
module->CalculateBoundingBox();
}
return module.release(); return module.release();
} }