realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix a few Coverity and compil warnings.

Browse Source
This commit is contained in:
jean-pierre charras 2024-10-18 18:10:42 +02:00
parent a5ada3230c
commit 90e65ffb34
4 changed files with 24 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
eeschema/sch_render_settings.cpp
View File

@ -41,6 +41,7 @@ SCH_RENDER_SETTINGS::SCH_RENDER_SETTINGS() :
m_ShowPinNumbers( false ),
m_ShowPinNames( false ),
m_ShowPinElectricalTypes( false ),
m_ShowPinAltIcons( false ),
m_ShowDisabled( false ),
m_ShowGraphicsDisabled( false ),
m_ShowConnectionPoints( false ),

3
eeschema/tools/sch_editor_control.cpp
View File

@ -1634,7 +1634,10 @@ int SCH_EDITOR_CONTROL::Paste( const TOOL_EVENT& aEvent )
content = GetClipboardUTF8();
if( content.empty() )
{
delete tempScreen;
return 0;
}
if( aEvent.IsAction( &ACTIONS::duplicate ) )
eventPos = getViewControls()->GetCursorPosition( false );

3
pcbnew/drc/drc_test_provider.cpp
View File

@ -45,7 +45,8 @@ DRC_TEST_PROVIDER_REGISTRY::~DRC_TEST_PROVIDER_REGISTRY()
DRC_TEST_PROVIDER::DRC_TEST_PROVIDER() :
UNITS_PROVIDER( pcbIUScale, EDA_UNITS::MILLIMETRES ),
m_drcEngine( nullptr )
m_drcEngine( nullptr ),
m_commit (nullptr )
{
}

36
pcbnew/drc/drc_test_provider_creepage.cpp
View File

@ -57,8 +57,8 @@ struct path_connection
bool m_forceA2concavityCheck = false;
/** @brief Test if a path is valid
*
/** @brief Test if a path is valid
*
* Check if a paths intersects the board edge or a track
*/
bool isValid( const BOARD& aBoard, PCB_LAYER_ID aLayer,
@ -208,7 +208,7 @@ class CU_SHAPE_CIRCLE;
class CU_SHAPE_ARC;
/** @class CREEP_SHAPE
*
*
* @brief A class used to represent the shapes for creepage calculation
*/
class CREEP_SHAPE
@ -308,7 +308,7 @@ protected:
/** @class CU_SHAPE
*
*
* @brief Creepage: a conductive shape
*/
class CU_SHAPE : public CREEP_SHAPE
@ -318,7 +318,7 @@ public:
};
/** @class BE_SHAPE
*
*
* @brief Creepage: a board edge shape
*/
class BE_SHAPE : public CREEP_SHAPE
@ -328,7 +328,7 @@ public:
};
/** @class CU_SHAPE_SEGMENT
*
*
* @brief Creepage: a conductive segment
*/
class CU_SHAPE_SEGMENT : public CU_SHAPE
@ -366,7 +366,7 @@ private:
};
/** @class CU_SHAPE_CIRCLE
*
*
* @brief Creepage: a conductive circle
*/
class CU_SHAPE_CIRCLE : public CU_SHAPE
@ -404,7 +404,7 @@ private:
};
/** @class CU_SHAPE_ARC
*
*
* @brief Creepage: a conductive arc
*/
class CU_SHAPE_ARC : public CU_SHAPE_CIRCLE
@ -473,7 +473,7 @@ private:
};
/** @class Graphnode
*
*
* @brief a node in a @class CreepageGraph
*/
class GraphNode
@ -513,7 +513,7 @@ public:
};
/** @class GraphConnection
*
*
* @brief a connection in a @class CreepageGraph
*/
class GraphConnection
@ -590,7 +590,7 @@ bool areEquivalent( const CREEP_SHAPE* a, const CREEP_SHAPE* b )
/** @class BE_SHAPE_POINT
*
*
* @brief Creepage: a board edge point
*/
class BE_SHAPE_POINT : public BE_SHAPE
@ -629,7 +629,7 @@ public:
};
/** @class BE_SHAPE_CIRCLE
*
*
* @brief Creepage: a board edge circle
*/
class BE_SHAPE_CIRCLE : public BE_SHAPE
@ -674,7 +674,7 @@ protected:
};
/** @class BE_SHAPE_ARC
*
*
* @brief Creepage: a board edge arc
*/
class BE_SHAPE_ARC : public BE_SHAPE_CIRCLE
@ -1104,7 +1104,7 @@ std::vector<path_connection> BE_SHAPE_CIRCLE::Paths( const BE_SHAPE_CIRCLE& aS2,
}
/** @class CreepageGraph
*
*
* @brief A graph with nodes and connections for creepage calculation
*/
class CreepageGraph
@ -1205,7 +1205,7 @@ void CreepageGraph::RemoveDuplicatedShapes()
size_t i = 0;
for( i = 0; i < m_shapeCollection.size() - 1; i++ )
for( i = 0; i < (int)m_shapeCollection.size() - 1; i++ )
{
if( m_shapeCollection[i] == nullptr )
continue;
@ -2861,7 +2861,7 @@ void CreepageGraph::Addshape( const SHAPE& aShape, GraphNode* aConnectTo, BOARD_
{
if( subshape )
{
// We don't want to add shape for the inner rectangle of rounded rectangles
// We don't want to add shape for the inner rectangle of rounded rectangles
if ( !( ( subshape->Type() == SH_RECT ) && ( nbShapes == 5 ) ))
Addshape( *subshape, aConnectTo, aParent );
}
@ -3333,7 +3333,7 @@ int DRC_TEST_PROVIDER_CREEPAGE::testCreepage( CreepageGraph& aGraph, int aNetCod
if( creepageValue <= 0 )
return 0;
// Let's make a quick "clearance test"
// Let's make a quick "clearance test"
NETINFO_ITEM* netA = m_board->FindNet( aNetCodeA );
NETINFO_ITEM* netB = m_board->FindNet( aNetCodeB );
@ -3430,7 +3430,7 @@ int DRC_TEST_PROVIDER_CREEPAGE::testCreepage( CreepageGraph& aGraph, int aNetCod
} );
reportViolation( drce, shortestPath[1]->m_path.a2, aLayer );
}
shortestPath.clear();