realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make sure that we are disconnected before dtor

Browse Source 
The child class removes itself from the parent panel, which calls the
DTOR.  This automatically disconnects the events, so if we want to
explicitly do this, we need to do it before freeing the memory

Fixes https://gitlab.com/kicad/code/kicad/-/issues/21307
This commit is contained in:
Seth Hillbrand 2025-07-12 12:07:56 -07:00
parent b165240118
commit 8b62eac886
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pcbnew/dialogs/panel_assign_component_classes.cpp
View File

@ -604,11 +604,10 @@ PANEL_COMPONENT_CLASS_CONDITION_REFERENCE::PANEL_COMPONENT_CLASS_CONDITION_REFER
void PANEL_COMPONENT_CLASS_CONDITION_REFERENCE::OnDeleteConditionClick( wxCommandEvent& event )
{
m_panelParent->RemoveCondition( this );
Disconnect( wxEVT_MENU,
wxCommandEventHandler( PANEL_COMPONENT_CLASS_CONDITION_REFERENCE::onMenu ), nullptr,
this );
m_panelParent->RemoveCondition( this );
}