realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Only test parameters under the same conditions as we'd write them to the file.

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21520
This commit is contained in:
Jeff Young 2025-09-08 12:44:43 +01:00
parent 0f97f51ba1
commit 8ae2ad3586
1 changed files with 21 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
pcbnew/drc/drc_test_provider_library_parity.cpp
View File

@ -334,23 +334,29 @@ bool padNeedsUpdate( const PAD* a, const PAD* b, REPORTER* aReporter )
PAD_DESC( a ),
layerName ) );
TEST_D( a->GetRoundRectRadiusRatio( layer ),
b->GetRoundRectRadiusRatio( layer ),
wxString::Format( _( "%s rounded corners differ on layer %s." ),
PAD_DESC( a ),
layerName ) );
if( a->GetShape( layer ) == PAD_SHAPE::ROUNDRECT || a->GetShape( layer ) == PAD_SHAPE::CHAMFERED_RECT)
{
TEST_D( a->GetRoundRectRadiusRatio( layer ),
b->GetRoundRectRadiusRatio( layer ),
wxString::Format( _( "%s rounded corners differ on layer %s." ),
PAD_DESC( a ),
layerName ) );
}
TEST_D( a->GetChamferRectRatio( layer ),
b->GetChamferRectRatio( layer ),
wxString::Format( _( "%s chamfered corner sizes differ on layer %s." ),
PAD_DESC( a ),
layerName ) );
if( a->GetShape( layer ) == PAD_SHAPE::CHAMFERED_RECT)
{
TEST_D( a->GetChamferRectRatio( layer ),
b->GetChamferRectRatio( layer ),
wxString::Format( _( "%s chamfered corner sizes differ on layer %s." ),
PAD_DESC( a ),
layerName ) );
TEST( a->GetChamferPositions( layer ),
b->GetChamferPositions( layer ),
wxString::Format( _( "%s chamfered corners differ on layer %s." ),
PAD_DESC( a ),
layerName ) );
TEST( a->GetChamferPositions( layer ),
b->GetChamferPositions( layer ),
wxString::Format( _( "%s chamfered corners differ on layer %s." ),
PAD_DESC( a ),
layerName ) );
}
TEST_PT( a->GetOffset( layer ), b->GetOffset( layer ),
wxString::Format( _( "%s shape offset from hole differs on layer %s." ),