realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Treat stacked pins as a single item in 4-way connection test.

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20532
This commit is contained in:
Jeff Young 2025-06-02 12:51:04 +01:00
parent fa687289bf
commit 8265950658
1 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
eeschema/erc/erc.cpp
View File

@ -792,6 +792,23 @@ int ERC_TESTER::TestFourWayJunction()
{
int err_count = 0;
auto pinStackAlreadyRepresented =
[]( SCH_PIN* pin, std::vector<SCH_ITEM*>& collection ) -> bool
{
for( SCH_ITEM*& item : collection )
{
if( item->Type() == SCH_PIN_T && item->GetParentSymbol() == pin->GetParentSymbol() )
{
if( pin->IsVisible() && !static_cast<SCH_PIN*>( item )->IsVisible() )
item = pin;
return true;
}
}
return false;
};
for( const SCH_SHEET_PATH& sheet : m_sheetList )
{
std::map<VECTOR2I, std::vector<SCH_ITEM*>> connMap;
@ -802,7 +819,15 @@ int ERC_TESTER::TestFourWayJunction()
SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
for( SCH_PIN* pin : symbol->GetPins( &sheet ) )
connMap[pin->GetPosition()].emplace_back( pin );
{
std::vector<SCH_ITEM*>& entry = connMap[pin->GetPosition()];
// Only one pin per pin-stack.
if( pinStackAlreadyRepresented( pin, entry ) )
continue;
entry.emplace_back( pin );
}
}
for( SCH_ITEM* item : screen->Items().OfType( SCH_LINE_T ) )