realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Pcbnew: efficiency and error-checking in footprint layers

Browse Source
This commit is contained in:
John Beard 2025-08-19 19:02:04 +08:00
parent 9173d11398
commit 811745ff96
1 changed files with 32 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
pcbnew/pcb_io/kicad_sexpr/pcb_io_kicad_sexpr_parser.cpp
View File

@ -5130,15 +5130,15 @@ void PCB_IO_KICAD_SEXPR_PARSER::parseFootprintStackup( FOOTPRINT& aFootprint )
case T_layer:
{
NeedSYMBOLorNUMBER();
const wxString layerName = CurText();
for( int layer = 0; layer < PCB_LAYER_ID_COUNT; ++layer )
const auto it = m_layerIndices.find( CurStr() );
if( it == m_layerIndices.end() )
{
if( LayerName( layer ) == layerName )
{
layers.set( ToLAYER_ID( layer ) );
break;
}
Expecting( "layer name" );
}
else
{
layers.set( it->second );
}
NeedRIGHT();
@ -5152,6 +5152,31 @@ void PCB_IO_KICAD_SEXPR_PARSER::parseFootprintStackup( FOOTPRINT& aFootprint )
}
}
// Check that the copper layers are sensible and contiguous
const LSET gotCuLayers = layers & LSET::AllCuMask();
// Remove this check when we support odd copper layer stackups
if( gotCuLayers.count() % 2 != 0 )
{
THROW_IO_ERROR( wxString::Format( _( "Invalid stackup in footprint: "
"odd number of copper layers (%d)." ),
gotCuLayers.count() ) );
}
const LSET expectedCuLayers = LSET::AllCuMask( gotCuLayers.count() );
if( gotCuLayers != expectedCuLayers )
{
THROW_IO_ERROR( wxString::Format( _( "Invalid stackup in footprint: "
"copper layers are not contiguous." ) ) );
}
if( ( layers & LSET::AllTechMask() ).count() > 0 )
{
THROW_IO_ERROR( wxString::Format( _( "Invalid stackup in footprint: "
"technology layers are implicit in footprints and "
"should not be specified in the stackup." ) ) );
}
// Set the mode first, so that the layer count is unlocked if needed
aFootprint.SetStackupMode( stackupMode );
aFootprint.SetStackupLayers( std::move( layers ) );