realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Handle ref & value proxies as if they were refs and values.

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20613
This commit is contained in:
Jeff Young 2025-04-13 15:06:14 +01:00
parent 66a7abca09
commit 57d0fa6f2d
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pcbnew/dialogs/dialog_global_edit_text_and_graphics.cpp
View File

@ -555,18 +555,20 @@ bool DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS::TransferDataFromWindow()
if( m_values->GetValue() )
visitItem( commit, &fp->Value() );
if( m_otherFootprintFields->GetValue() )
for( PCB_FIELD* field : fp->GetFields() )
{
for( PCB_FIELD* field : fp->GetFields() )
{
if( field->IsReference() )
continue;
if( field->IsReference() )
continue;
if( field->IsValue() )
continue;
if( field->IsValue() )
continue;
if( m_otherFootprintFields->GetValue() )
visitItem( commit, field );
else if( m_references->GetValue() && field->GetText() == wxT( "${REFERENCE}" ) )
visitItem( commit, field );
else if( m_values->GetValue() && field->GetText() == wxT( "${VALUE}" ) )
visitItem( commit, field );
}
}
// Go through all other footprint items
@ -576,8 +578,14 @@ bool DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS::TransferDataFromWindow()
if( itemType == PCB_TEXT_T || itemType == PCB_TEXTBOX_T )
{
EDA_TEXT* textItem = dynamic_cast<EDA_TEXT*>( boardItem );
if( m_footprintTexts->GetValue() )
visitItem( commit, boardItem );
else if( m_references->GetValue() && textItem->GetText() == wxT( "${REFERENCE}" ) )
visitItem( commit, boardItem );
else if( m_values->GetValue() && textItem->GetText() == wxT( "${VALUE}" ) )
visitItem( commit, boardItem );
}
else if( BaseType( itemType ) == PCB_DIMENSION_T )
{