From 31be74b8b3a1c27a2c9da35ff09c47dbd73480b5 Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Mon, 20 Feb 2023 09:16:33 +0100 Subject: [PATCH] Fix a few Coverity warnings --- common/view/view_controls.cpp | 1 + eeschema/eeschema_jobs_handler.cpp | 9 +++++++++ eeschema/sim/sim_plot_frame.cpp | 4 +++- include/plotters/plotters_pslike.h | 3 ++- 4 files changed, 15 insertions(+), 2 deletions(-) diff --git a/common/view/view_controls.cpp b/common/view/view_controls.cpp index e13fa778c9..690043db6e 100644 --- a/common/view/view_controls.cpp +++ b/common/view/view_controls.cpp @@ -62,6 +62,7 @@ void VC_SETTINGS::Reset() m_cursorCaptured = false; m_snappingEnabled = true; m_grabMouse = false; + m_focusFollowSchPcb = false; m_autoPanEnabled = false; m_autoPanSettingEnabled = false; m_autoPanMargin = 0.02f; diff --git a/eeschema/eeschema_jobs_handler.cpp b/eeschema/eeschema_jobs_handler.cpp index c3140cc1b1..b16cb23774 100644 --- a/eeschema/eeschema_jobs_handler.cpp +++ b/eeschema/eeschema_jobs_handler.cpp @@ -283,6 +283,9 @@ int EESCHEMA_JOBS_HANDLER::JobExportPythonBom( JOB* aJob ) { JOB_EXPORT_SCH_PYTHONBOM* aNetJob = dynamic_cast( aJob ); + if( !aNetJob ) + return CLI::EXIT_CODES::ERR_UNKNOWN; + SCHEMATIC* sch = EESCHEMA_HELPERS::LoadSchematic( aNetJob->m_filename, SCH_IO_MGR::SCH_KICAD ); if( sch == nullptr ) @@ -449,6 +452,9 @@ int EESCHEMA_JOBS_HANDLER::JobSymExportSvg( JOB* aJob ) { JOB_SYM_EXPORT_SVG* svgJob = dynamic_cast( aJob ); + if( !svgJob ) + return CLI::EXIT_CODES::ERR_UNKNOWN; + wxFileName fn( svgJob->m_libraryPath ); fn.MakeAbsolute(); @@ -512,6 +518,9 @@ int EESCHEMA_JOBS_HANDLER::JobSymUpgrade( JOB* aJob ) { JOB_SYM_UPGRADE* upgradeJob = dynamic_cast( aJob ); + if( !upgradeJob ) + return CLI::EXIT_CODES::ERR_UNKNOWN; + wxFileName fn( upgradeJob->m_libraryPath ); fn.MakeAbsolute(); diff --git a/eeschema/sim/sim_plot_frame.cpp b/eeschema/sim/sim_plot_frame.cpp index 1bd8c744c4..91f1199dc9 100644 --- a/eeschema/sim/sim_plot_frame.cpp +++ b/eeschema/sim/sim_plot_frame.cpp @@ -156,7 +156,9 @@ class SIGNALS_GRID_TRICKS : public GRID_TRICKS public: SIGNALS_GRID_TRICKS( SIM_PLOT_FRAME* aParent, WX_GRID* aGrid ) : GRID_TRICKS( aGrid ), - m_parent( aParent ) + m_parent( aParent ), + m_menuRow( 0 ), + m_menuCol( 0 ) {} protected: diff --git a/include/plotters/plotters_pslike.h b/include/plotters/plotters_pslike.h index 2da0189301..6628ddd03b 100644 --- a/include/plotters/plotters_pslike.h +++ b/include/plotters/plotters_pslike.h @@ -244,7 +244,8 @@ public: m_fontResDictHandle( 0 ), m_pageStreamHandle( 0 ), m_streamLengthHandle( 0 ), - m_workFile( nullptr ) + m_workFile( nullptr ), + m_totalOutlineNodes( 0 ) { }