realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

QA: side-step wxSize printer not working for some

Browse Source 
Not sure what it is that caused it to break (reported by
Seth on Linux, but works for me and on the CI).

Rather than trying to be clever at this point, just do the dumb
thing (and remove the boost_test_print_type for wxSize to prevent
someone using it for the time being).
This commit is contained in:
John Beard 2025-02-01 00:09:29 +08:00
parent a7f5fc45e7
commit 30affcd7a1
3 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qa/qa_utils/include/qa_utils/wx_utils/unit_test_utils.h
View File

@ -142,8 +142,6 @@ std::ostream& boost_test_print_type( std::ostream& os, std::pair<K, V> const& aP
*/
std::ostream& boost_test_print_type( std::ostream& os, wxPoint const& aVec );
std::ostream& boost_test_print_type( std::ostream& os, wxSize const& aSize );
namespace KI_TEST
{

7
qa/qa_utils/wx_utils/unit_test_utils.cpp
View File

@ -31,13 +31,6 @@ std::ostream& boost_test_print_type( std::ostream& os, wxPoint const& aPt )
}
std::ostream& boost_test_print_type( std::ostream& os, wxSize const& aSize )
{
os << "wxSize[ x=\"" << aSize.x << "\" y=\"" << aSize.y << "\" ]";
return os;
}
std::string KI_TEST::GetEeschemaTestDataDir()
{
const char* env = std::getenv( "KICAD_TEST_EESCHEMA_DATA_DIR" );

5
qa/tests/common/wximage_test_utils.cpp
View File

@ -61,7 +61,10 @@ bool ImagesHaveSamePixels( const wxImage& aImgA, const wxImage& aImgB )
{
if( aImgA.GetSize() != aImgB.GetSize() )
{
BOOST_TEST_INFO( "Image sizes differ: " << aImgA.GetSize() << " vs " << aImgB.GetSize() );
BOOST_TEST_INFO( "Image sizes differ: " << aImgA.GetSize().GetWidth() << "x"
<< aImgA.GetSize().GetHeight() << " vs "
<< aImgB.GetSize().GetWidth() << "x"
<< aImgB.GetSize().GetHeight() );
return false;
}