realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

cvpcb: Testing theory on save hotkey override

Browse Source 
Bug #1807567 states the entering 's' in the string search textbox does
not get passed to the text box correctly when in the German language
under windows.  This likely means that the main window is firing wxSave
when it detects the 's' key.  By adjusting the id for the save and
continue action, we hope to allow the signal to pass through to the
textbox. This commit should otherwise be a NOP.

N.B. This appears to be the result of hooking wxEVT_CHAR_HOOK into
EDA_DRAW_PANEL::OnKeyEvent() (commit
53b1ec81462727eec770204b57cadbabdcfc57de) that reverses the cascade of
events from bottom up rather than top down.  Fixing that is a longer
project and will likely be a side effect of switching fully to the new
tool architecture.
This commit is contained in:
Seth Hillbrand 2019-02-14 20:50:50 -08:00
parent a02f447daa
commit 2948f8a6bc
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cvpcb/cvpcb_mainframe.cpp
View File

@ -63,7 +63,7 @@ static const wxString FilterFootprintEntry = "FilterFootprint";
BEGIN_EVENT_TABLE( CVPCB_MAINFRAME, KIWAY_PLAYER )
// Menu events
EVT_MENU( wxID_SAVE, CVPCB_MAINFRAME::OnSaveAndContinue )
EVT_MENU( ID_SAVE_PROJECT, CVPCB_MAINFRAME::OnSaveAndContinue )
EVT_MENU( wxID_EXIT, CVPCB_MAINFRAME::OnQuit )
EVT_MENU( wxID_HELP, CVPCB_MAINFRAME::GetKicadHelp )
EVT_MENU( wxID_ABOUT, CVPCB_MAINFRAME::GetKicadAbout )
@ -189,7 +189,7 @@ CVPCB_MAINFRAME::CVPCB_MAINFRAME( KIWAY* aKiway, wxWindow* aParent ) :
auto buttonsSizer = new wxBoxSizer( wxHORIZONTAL );
auto sdbSizer = new wxStdDialogButtonSizer();
m_saveAndContinue = new wxButton( bottomPanel, wxID_SAVE,
m_saveAndContinue = new wxButton( bottomPanel, ID_SAVE_PROJECT,
_( "Apply, Save Schematic && Continue" ) );
buttonsSizer->Add( m_saveAndContinue, 0, wxALIGN_CENTER_VERTICAL|wxRIGHT, 20 );

2
cvpcb/menubar.cpp
View File

@ -53,7 +53,7 @@ void CVPCB_MAINFRAME::ReCreateMenuBar()
wxMenu* filesMenu = new wxMenu;
// Save the footprints back into eeschema
AddMenuItem( filesMenu, wxID_SAVE,
AddMenuItem( filesMenu, ID_SAVE_PROJECT,
_( "&Save Schematic\tCtrl+S" ),
SAVE_HLP_MSG,
KiBitmap( save_xpm ) );