realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Attempt to improve ever-growing-window problems.

Browse Source
This commit is contained in:
Jeff Young 2025-09-01 10:28:42 +01:00
parent 5b31b11731
commit 1f44417ad0
2 changed files with 10 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/widgets/bitmap_button.cpp
View File

@ -284,7 +284,7 @@ void BITMAP_BUTTON::OnDPIChanged( wxDPIChangedEvent& aEvent )
invalidateBestSize();
}
aEvent.Skip();
// Don't skip, otherwise the button gets too big
}

28
common/widgets/wx_grid.cpp
View File

@ -76,8 +76,7 @@ wxGridCellAttr* WX_GRID_TABLE_BASE::enhanceAttr( wxGridCellAttr* aInputAttr, int
void WX_GRID::CellEditorSetMargins( wxTextEntryBase* aEntry )
{
// This is consistent with wxGridCellTextEditor. But works differently across platforms or
// course.
// This is consistent with wxGridCellTextEditor. But works differently across platforms of course.
aEntry->SetMargins( 0, 0 );
}
@ -202,13 +201,12 @@ private:
};
WX_GRID::WX_GRID( wxWindow *parent, wxWindowID id, const wxPoint& pos, const wxSize& size,
long style, const wxString& name ) :
WX_GRID::WX_GRID( wxWindow *parent, wxWindowID id, const wxPoint& pos, const wxSize& size, long style,
const wxString& name ) :
wxGrid( parent, id, pos, size, style, name ),
m_weOwnTable( false )
{
// Grids with comboboxes need a bit of extra height; other grids look better if they're
// consistent.
// Grids with comboboxes need a bit of extra height; other grids look better if they're consistent.
SetDefaultRowSize( GetDefaultRowSize() + FromDIP( 4 ) );
SetDefaultCellOverflow( false );
@ -241,11 +239,7 @@ void WX_GRID::onDPIChanged(wxDPIChangedEvent& aEvt)
wxGrid::SetColLabelSize( wxGRID_AUTOSIZE );
} );
/// This terrible hack is a way to avoid the incredibly disruptive resizing of grids that
/// happens on Macs when moving a window between monitors of different DPIs.
#ifndef __WXMAC__
aEvt.Skip();
#endif
// Don't skip, otherwise the grid gets too big
}
@ -422,8 +416,7 @@ void WX_GRID::onCellEditorHidden( wxGridEvent& aEvent )
}
else
{
val = unitsProvider->OptionalValueFromString( m_eval->Result(),
cellDataType );
val = unitsProvider->OptionalValueFromString( m_eval->Result(), cellDataType );
}
evalValue = unitsProvider->StringFromOptionalValue( val, true, cellDataType );
@ -518,8 +511,7 @@ void WX_GRID::DrawCornerLabel( wxDC& dc )
static WX_GRID_CORNER_HEADER_RENDERER rend;
// It is reported that we need to erase the background to avoid display
// artifacts, see #12055.
// It is reported that we need to erase the background to avoid display artifacts; see #12055.
{
wxDCBrushChanger setBrush( dc, m_colLabelWin->GetBackgroundColour() );
wxDCPenChanger setPen( dc, m_colLabelWin->GetBackgroundColour() );
@ -542,8 +534,7 @@ void WX_GRID::DrawColLabel( wxDC& dc, int col )
static WX_GRID_COLUMN_HEADER_RENDERER rend;
// It is reported that we need to erase the background to avoid display
// artifacts, see #12055.
// It is reported that we need to erase the background to avoid display artifacts; see #12055.
{
wxDCBrushChanger setBrush( dc, m_colLabelWin->GetBackgroundColour() );
wxDCPenChanger setPen( dc, m_colLabelWin->GetBackgroundColour() );
@ -578,8 +569,7 @@ void WX_GRID::DrawRowLabel( wxDC& dc, int row )
static WX_GRID_ROW_HEADER_RENDERER rend;
// It is reported that we need to erase the background to avoid display
// artifacts, see #12055.
// It is reported that we need to erase the background to avoid display artifacts; see #12055.
{
wxDCBrushChanger setBrush( dc, m_colLabelWin->GetBackgroundColour() );
wxDCPenChanger setPen( dc, m_colLabelWin->GetBackgroundColour() );