From 0c99c99e12ccdae2acc32e28d6644a0e744584c0 Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Tue, 26 Oct 2021 11:16:04 -0700 Subject: [PATCH] Do not assign priorities to rule areas As noted by @jeffyoung, we shouldn't set priorities to rule areas as this can expose unexpected issues Related to https://gitlab.com/kicad/code/kicad/-/issues/7776 --- pcbnew/plugins/fabmaster/import_fabmaster.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pcbnew/plugins/fabmaster/import_fabmaster.cpp b/pcbnew/plugins/fabmaster/import_fabmaster.cpp index 7e19111b0b..8a1efec4ea 100644 --- a/pcbnew/plugins/fabmaster/import_fabmaster.cpp +++ b/pcbnew/plugins/fabmaster/import_fabmaster.cpp @@ -2675,8 +2675,11 @@ bool FABMASTER::loadZone( BOARD* aBoard, const std::unique_ptr zone->SetIsRuleArea( true ); zone->SetDoNotAllowVias( true ); } + else + { + zone->SetPriority( 50 ); + } - zone->SetPriority( 50 ); zone->SetLocalClearance( 0 ); zone->SetPadConnection( ZONE_CONNECTION::FULL ); @@ -2947,6 +2950,10 @@ bool FABMASTER::orderZones( BOARD* aBoard ) for( ZONE* zone : zones ) { + /// Rule areas do not have priorities + if( zone->GetIsRuleArea() ) + continue; + if( zone->GetLayer() != layer ) { layer = zone->GetLayer();