realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Only report single-file issues in single-file-mode.

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20891
This commit is contained in:
Jeff Young 2025-05-14 16:22:53 +01:00
parent 38385340b1
commit 085af89381
1 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
pcbnew/dialogs/dialog_export_odbpp.cpp
View File

@ -307,42 +307,47 @@ void DIALOG_EXPORT_ODBPP::GenerateODBPPFiles( const JOB_EXPORT_PCB_ODB& aJob, BO
if( outputFn.GetPath().IsEmpty() && outputFn.HasName() )
outputFn.MakeAbsolute();
bool outputIsSingleFile = aJob.m_compressionMode != JOB_EXPORT_PCB_ODB::ODB_COMPRESSION::NONE;
wxString msg;
if( !PATHS::EnsurePathExists( outputFn.GetPath(),
aJob.m_compressionMode != JOB_EXPORT_PCB_ODB::ODB_COMPRESSION::NONE ) )
if( !PATHS::EnsurePathExists( outputFn.GetPath(), outputIsSingleFile ) )
{
msg.Printf( _( "Cannot create output directory '%s'." ), outputFn.GetFullPath() );
if( aReporter )
aReporter->Report( msg, RPT_SEVERITY_ERROR );
return;
}
if( outputFn.IsDir() && !outputFn.IsDirWritable() )
{
msg.Printf( _( "Insufficient permissions to folder '%s'." ), outputFn.GetPath() );
}
else if( !outputFn.FileExists() && !outputFn.IsDirWritable() )
{
msg.Printf( _( "Insufficient permissions to save file '%s'." ), outputFn.GetFullPath() );
}
else if( outputFn.FileExists() && !outputFn.IsFileWritable() )
{
msg.Printf( _( "Insufficient permissions to save file '%s'." ), outputFn.GetFullPath() );
}
if( !msg.IsEmpty() )
{
if( aReporter )
aReporter->Report( msg, RPT_SEVERITY_ERROR );
return;
}
if( outputIsSingleFile )
{
bool writeable = outputFn.FileExists() ? outputFn.IsFileWritable() : outputFn.IsDirWritable();
if( !writeable )
{
msg.Printf( _( "Insufficient permissions to save file '%s'." ), outputFn.GetFullPath() );
if( aReporter )
aReporter->Report( msg, RPT_SEVERITY_ERROR );
return;
}
}
wxFileName tempFile( outputFn.GetFullPath() );
if( aJob.m_compressionMode != JOB_EXPORT_PCB_ODB::ODB_COMPRESSION::NONE )
if( outputIsSingleFile )
{
if( outputFn.Exists() )
{