realAscot/kicad-source
1
0
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-09-14 02:03:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix stale data crash when updating delay profile data

Browse Source
This commit is contained in:
JamesJCode 2025-04-18 23:56:21 +01:00
parent 846ffa5659
commit 0331ecb173
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pcbnew/pcb_edit_frame.cpp
View File

@ -1393,6 +1393,9 @@ void PCB_EDIT_FRAME::ShowBoardSetupDialog( const wxString& aInitialPage )
// QuasiModal required for Scintilla auto-complete // QuasiModal required for Scintilla auto-complete
if( dlg.ShowQuasiModal() == wxID_OK ) if( dlg.ShowQuasiModal() == wxID_OK )
{ {
// Note: We must synchronise time domain properties before nets and classes, otherwise the updates
// called by the board listener events are using stale data
GetBoard()->SynchronizeTimeDomainProperties();
GetBoard()->SynchronizeNetsAndNetClasses( true ); GetBoard()->SynchronizeNetsAndNetClasses( true );
if( !GetBoard()->SynchronizeComponentClasses( std::unordered_set<wxString>() ) ) if( !GetBoard()->SynchronizeComponentClasses( std::unordered_set<wxString>() ) )
@ -1403,8 +1406,6 @@ void PCB_EDIT_FRAME::ShowBoardSetupDialog( const wxString& aInitialPage )
wxICON_WARNING, WX_INFOBAR::MESSAGE_TYPE::GENERIC ); wxICON_WARNING, WX_INFOBAR::MESSAGE_TYPE::GENERIC );
} }
GetBoard()->SynchronizeTimeDomainProperties();
// We don't know if anything was modified, so err on the side of requiring a save // We don't know if anything was modified, so err on the side of requiring a save
OnModify(); OnModify();